This repository has been archived by the owner on May 16, 2024. It is now read-only.
[MV-405] Fix deeplinking when app is in background #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyman503
reviewed
Apr 18, 2023
There was a problem hiding this comment.
The changes look ok to me and they works as you described it. However I'm not sure about the behaviour when user is currently in call. In my opinion in that case we should first display to the user some popup/modal informing them that they're about to leave a call before force moving them to the join room screen. Wdyt?
|
@skyman503 good idea, I've added the modal 👍 |
skyman503
approved these changes
Apr 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug can be reproduced by trying to click a link when app was in Room or Leave screen. The JoinRoom screen was not mounted at all so there was no way to navigate to it.
Now all screens are in the same stack, not conditionally rendered with this fix: react-navigation/react-navigation#11315
Pro tip for fast testing on android:
adb shell am start -W -a android.intent.action.VIEW -d "https://videoroom.membrane.work/room/Membrane%20Frontend%20Stand-up" com.membrane.reactnativemembranesimulates a deeplink clickon iOS there is a similar command